MAINT: Only output errors in C style check #14924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.64% (diff: 100%)@@ master #14924 diff @@
==========================================
Files 144 144
Lines 51019 51019
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43188 43187 -1
- Misses 7831 7832 +1
Partials 0 0
|
|
lgtm. can you also move the pip install cpplint to the top of lint.sh (so it doesn't mess up the output). ping when pushed. |
|
@jreback : Moved |
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Dec 20, 2016
* MAINT: Only output errors in C style check * Move cpplint install before checks
ShaharBental
pushed a commit
to ShaharBental/pandas
that referenced
this pull request
Dec 26, 2016
* MAINT: Only output errors in C style check * Move cpplint install before checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self-explanatory. Follow-up to #14814.