TST: confirming tests for some fixed issues #14117
Conversation
jorisvandenbossche
changed the title
jorisvandenbossche
changed the title
jorisvandenbossche
added
the
Testing
Current coverage is 85.27% (diff: 100%)@@ master #14117 diff @@
==========================================
Files 139 139
Lines 50543 50543
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43101 43102 +1
+ Misses 7442 7441 -1
Partials 0 0
|
jorisvandenbossche
force-pushed
the
various-tests
branch
from
7eb016f to
4b246ef
Compare
| @@ -1788,3 +1788,11 @@ def test_value_counts_categorical_not_ordered(self): | |||
| index=exp_idx, name='xxx') | |||
| tm.assert_series_equal(s.value_counts(normalize=True), exp) | |||
| tm.assert_series_equal(idx.value_counts(normalize=True), exp) | |||
|
|
|||
| def test_nat_operations(self): | |||
There was a problem hiding this comment.
not the right place for this. maybe in tseries/tests_timeseries
There was a problem hiding this comment.
yep, I was not sure where to put this. Finding a place to put a test it a good way to get lost :-)
but note that it is not a timeseries (in the sense of a series having a datetime index), so it would also be strange to put it in tseries/test_timeseries.
There was a problem hiding this comment.
OK, I see that TestTimeSeries mixes tests for both cases (dt index or dt values), so will put it there.
(although I would find it more logical to separate those)
|
@jorisvandenbossche #6817 is not the right issue. can you update. (at the top of the PR) |
jorisvandenbossche
force-pushed
the
various-tests
branch
from
4b246ef to
252facb
Compare
|
@jreback whoops, updated (the commit message contained the correct number) |
closes #7710, closes #8617, closes #13119
Closes a few issues still tagged with 0.19.0 that only need a confirming test