Skip to content

BUG: Categoricals shouldn't allow non-strings when object dtype is passed (#13919) #14047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

BUG: Categoricals shouldn't allow non-strings when object dtype is passed (#13919) #14047

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9b091f
BUG: Categoricals shouldn't allow non-strings when object dtype is pa…
wcwagner Aug 18, 2016
2730600
Fixed typo in whatsnew entry
wcwagner Aug 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed typo in whatsnew entry
  • Loading branch information
@wcwagner
wcwagner committed Aug 19, 2016
commit 2730600272f9bb10ebeeb0e0aef98e5a2a40d3d9
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.19.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,4 +1075,4 @@ Bug Fixes
- Bug in ``Index`` raises ``KeyError`` displaying incorrect column when column is not in the df and columns contains duplicate values (:issue:`13822`)
- Bug in ``Period`` and ``PeriodIndex`` creating wrong dates when frequency has combined offset aliases (:issue:`13874`)
- Bug in ``.to_string()`` when called with an integer ``line_width`` and ``index=False`` raises an UnboundLocalError exception because ``idx`` referenced before assignment.
- Bug in ``Categorical`` would allow creation when ``object`` dtype was passed in with categories not containing either all non-string or all non-period values
- Bug in ``Categorical`` would allow creation when ``object`` dtype was passed in with categories not containing either all string or all period values
Copy link
Member

@sinhrks sinhrks Aug 19, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is a bug. Pls move this to API change section, and needs more detailed descriptions as it breaks existing user's code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just say mixed dtype categoricals