Skip to content

BUG: fixed SAS7BDATReader._get_properties #12658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

BUG: fixed SAS7BDATReader._get_properties #12658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
BUG: fixed SAS7BDATReader._get_properties 
self._path_or_buf.read is an obvious mistake

also added + total_align to _os_name_offset and _os_make_offset as they are
present in the original code from Jared Hobbs:
https://bitbucket.org/jaredhobbs/sas7bdat/src/da1faa90d0b15c2c97a2a8eb86c91c58081bdd86/sas7bdat.py?fileviewer=file-view-default#sas7bdat.py-1450
  • Loading branch information
@gdementen
gdementen committed Mar 17, 2016
commit 1ed5f8c6f83c6fc63dee20c74df780426fe9ea8e
9 changes: 5 additions & 4 deletions pandas/io/sas/sas7bdat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,12 +327,13 @@ def _get_properties(self):
_os_version_number_length)
self.os_version = buf.rstrip(b'\x00 ').decode()

buf = self._read_bytes(
_os_name_offset, _os_name_length).rstrip(b'\x00 ')
buf = self._read_bytes(_os_name_offset + total_align,
_os_name_length).rstrip(b'\x00 ')
if len(buf) > 0:
self.os_name = buf.rstrip(b'\x00 ').decode()
self.os_name = buf.decode()
else:
buf = self._path_or_buf.read(_os_maker_offset, _os_maker_length)
buf = self._read_bytes(_os_maker_offset + total_align,
_os_maker_length)
self.os_name = buf.rstrip(b'\x00 ').decode()

# Read a single float of the given width (4 or 8).
Expand Down