ENH Enable bzip2 streaming for Python 3 #11072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests! |
stephen-hoover
force-pushed
the
stream-bzip2-files
branch
from
9c95929 to
5e2b1b7
Compare
|
I added a test for reading from an open file with the C parser. It fails on the master branch and passes here. How's that? |
|
do you have exactly the same deps |
|
Yes, exactly the same dependencies. This PR works because the standard library |
jreback
added
IO Data
|
ok, this looks good. pls add a note in whatsnew for 0.17.0 (just released the rc1 yesterday, but this is ok). reference both the original issue and this PR number I think. squash & ping when green. |
stephen-hoover
force-pushed
the
stream-bzip2-files
branch
from
5e2b1b7 to
7fb36b7
Compare
|
Note added. It doesn't look like anything else references a PR; should I leave that reference in? |
doc/source/whatsnew/v0.17.0.txt
Outdated
There was a problem hiding this comment.
just reference it like an issue :issue:11072``, we don't distinguish
4 tasks
Python 2 can't read bz2 files, but Python 3 can. Python 3 can also read bzip files one piece at a time.
stephen-hoover
force-pushed
the
stream-bzip2-files
branch
from
7fb36b7 to
636afbe
Compare
|
@jreback , tests are green! |
jreback
added a commit
that referenced
this pull request
Sep 13, 2015
ENH Enable bzip2 streaming for Python 3
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the one modification related to issue #11070 which affects non-S3 interactions with
read_csv. The Python 3 standard library has an improved capability for handling bz2 compression, so a simple change will letread_csvstream bz2-compressed files.