Skip to content

ENH Recognize 's3n' and 's3a' as an S3 address #11071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2015
Merged

ENH Recognize 's3n' and 's3a' as an S3 address #11071

merged 1 commit into from
Sep 14, 2015

Conversation

stephen-hoover
Copy link
Contributor

This PR allows read_csv to recognize that "s3n://" designates a valid AWS S3 address. Partially addresses issue #11070 .

jreback
jreback reviewed Sep 12, 2015
View reviewed changes
pandas/io/tests/test_parsers.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertTrue

and like

@stephen-hoover stephen-hoover changed the title ENH Recognize 's3n' as an S3 address ENH Recognize 's3n' and 's3a' as an S3 address Sep 12, 2015
@stephen-hoover
Copy link
Contributor Author

Fixed. I also realized (reading the links I added for issue #11070 ) that "s3a" is a valid S3 designator as well, so I added that too.

@stephen-hoover
Copy link
Contributor Author

The one test failure appears unrelated to the code change in this PR:

FAIL: test_numeric_column_names (pandas.io.tests.test_stata.TestStata)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/pydata/pandas/pandas/io/tests/test_stata.py", line 480, in test_numeric_column_names
    original.to_stata(path)
  File "/home/travis/miniconda/envs/pandas/lib/python3.3/contextlib.py", line 55, in __exit__
    next(self.gen)
  File "/home/travis/build/pydata/pandas/pandas/util/testing.py", line 2021, in assert_produces_warning
    % extra_warnings)
AssertionError: Caused unexpected warning(s): ['ResourceWarning'].

@jreback
Copy link
Contributor

jreback commented Sep 12, 2015

no it's just hitting the actual error there
you have something failing

@jreback jreback added the IO Data IO issues that don't fit into a more specific label label Sep 12, 2015
@stephen-hoover stephen-hoover mentioned this pull request Sep 12, 2015
Closed
4 tasks
@stephen-hoover stephen-hoover force-pushed the recognize-s3n branch 2 times, most recently from 1ab4a4b to 3f29254 Compare September 13, 2015 18:16
@jreback
Copy link
Contributor

jreback commented Sep 13, 2015

add a whatsnew note in 0.17.0 (enhancements section)

@jreback jreback added this to the 0.17.0 milestone Sep 13, 2015
@stephen-hoover
Copy link
Contributor Author

@jreback , green here too!

jreback added a commit that referenced this pull request Sep 14, 2015
@jreback
Merge pull request #11071 from stephen-hoover/recognize-s3n
95110ac 
ENH Recognize 's3n' and 's3a' as an S3 address
@jreback jreback merged commit 95110ac into pandas-dev:master Sep 14, 2015
@jreback
Copy link
Contributor

jreback commented Sep 14, 2015

thanks!

@stephen-hoover stephen-hoover deleted the recognize-s3n branch September 14, 2015 20:09
@TomAugspurger TomAugspurger mentioned this pull request Jun 2, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO Data IO issues that don't fit into a more specific label
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stephen-hoover @jreback