Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add missing methods to .dt for Period #8848

Closed
jreback opened this issue Nov 18, 2014 · 2 comments
Closed

ENH: add missing methods to .dt for Period #8848

jreback opened this issue Nov 18, 2014 · 2 comments
Labels
API Design Compat pandas objects compatability with Numpy or Python functions Period Period data type
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Nov 18, 2014

methods

  • to_timestamp
  • asfreq

properties

  • start_time/end_time
@jreback jreback added Good as first PR API Design Period Period data type Compat pandas objects compatability with Numpy or Python functions labels Nov 18, 2014
@jreback jreback added this to the 0.16.0 milestone Nov 18, 2014
@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 6, 2015
@rosnfeld
Copy link
Contributor

@jreback I just want to make sure I understand this issue. If there's a series of Period objects, there are some additional methods desired on the .dt accessor? And these would be the same for PeriodIndex, as from looking at the code it seems that PeriodIndex is what's really behind the scenes of the .dt accessor?

I should note there's a whole host of methods that are available to datetime_series.dt that aren't on period_series.dt, including: ceil/floor/round, is_{month,quarter,year}_{start,end}, microsecond, nanosecond, normalize, tz, tz_convert, tz_localize.

@rosnfeld
Copy link
Contributor

Now that I've played with this code a bit, not sure a lot of those methods make sense for PeriodIndex/period_series.dt. I think a new issue can be raised if some of them should be implemented. (a harder task than what this issue was, which was mostly just exposing on .dt what was already done on PeriodIndex)

@jreback jreback modified the milestones: 0.18.0, Next Major Release Feb 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Compat pandas objects compatability with Numpy or Python functions Period Period data type
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants