Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push some of Series.ix into Series.__getitem__/__setitem__ #86

Closed
wesm opened this issue Jul 30, 2011 · 5 comments
Closed

Push some of Series.ix into Series.__getitem__/__setitem__ #86

wesm opened this issue Jul 30, 2011 · 5 comments
Milestone

Comments

@wesm
Copy link
Member

wesm commented Jul 30, 2011

Should be able to do stuff like:

ts[date1:date2]

to mirror ts.ix[date1:date2]. Should respect integer labels while Series.ix will not

@changhiskhan
Copy link
Contributor

Why not push all of it into getitem/setitem?

def getitem(self, key):
self.ix[key]

def setitem(self, key, value):
self.ix[key] = value

@wesm
Copy link
Member Author

wesm commented Nov 13, 2011

Oof. Please steer clear of this issue, it's full of performance landmines. I need to set up some benchmarks so I can evaluate all of the use cases

@wesm
Copy link
Member Author

wesm commented Nov 13, 2011

In principle having all of it in getitem/setitem would be nice. but the use cases are complex

@changhiskhan
Copy link
Contributor

sounds like a reasonable approach. i'll let you take this one then :)

wesm added a commit that referenced this issue Jan 13, 2012
…o implement #86, related tightening of integer index handling from #592
@wesm
Copy link
Member Author

wesm commented Jan 13, 2012

Alright, this is done. Need to document the related API changes and add lots of WARNING, WARNING

@wesm wesm closed this as completed Jan 13, 2012
@Tiaonmmn Tiaonmmn mentioned this issue Nov 3, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants