Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: rename PandasArray -> NumpyExtensionArray #53694

Closed
3 tasks done
jbrockmendel opened this issue Jun 15, 2023 · 3 comments · Fixed by #54101
Closed
3 tasks done

API: rename PandasArray -> NumpyExtensionArray #53694

jbrockmendel opened this issue Jun 15, 2023 · 3 comments · Fixed by #54101
Labels
API Design ExtensionArray Extending pandas with custom dtypes or arrays. Refactor Internal refactoring of code

Comments

@jbrockmendel
Copy link
Member

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

NA

Issue Description

More neutral naming scheme analogous to ArrowExtensionArray.

Expected Behavior

NA

Installed Versions

Replace this line with the output of pd.show_versions()
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 15, 2023
@lithomas1 lithomas1 added Refactor Internal refactoring of code API Design ExtensionArray Extending pandas with custom dtypes or arrays. and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 19, 2023
@SanjithChockan
Copy link
Contributor

take

@jbrockmendel jbrockmendel mentioned this issue Jun 21, 2023
Open
@SanjithChockan SanjithChockan removed their assignment Jun 23, 2023
@jbrockmendel
Copy link
Member Author

@TomAugspurger i think PandasArray was your idea initially. any objection to renaming?

@TomAugspurger
Copy link
Contributor

Works for me.

@jbrockmendel jbrockmendel mentioned this issue Jul 12, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design ExtensionArray Extending pandas with custom dtypes or arrays. Refactor Internal refactoring of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REF: rename PandasArray->NumpyExtensionArray jbrockmendel/pandas
4 participants
@TomAugspurger @jbrockmendel @SanjithChockan @lithomas1