-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Joining MultiIndex with IntervalIndex level fails when IntervalIndex level is overlapping #44096
Closed
3 tasks done
Labels
Milestone
Comments
johannes-mueller
added
Bug
Needs Triage
Issue that has not been reviewed by a pandas team member
labels
Oct 19, 2021
mroeschke
added
Reshaping
Concat, Merge/Join, Stack/Unstack, Explode
and removed
Needs Triage
Issue that has not been reviewed by a pandas team member
labels
Oct 30, 2021
johannes-mueller
added a commit
to boschresearch/pandas
that referenced
this issue
Nov 23, 2021
…#44096) `BaseMultiIndexCodesEngine._extract_level_codes` relies on the assumption that `get_indexer()` is always usable as any index level `is_unique`. However, that is not the case for overlapping `IntervalIndex` levels. `get_indexer()` can not be used on an `IntervalIndex` that `is_overlapping` even if it `is_unique`. This patch checks if the index level is an overlapping `IntervalIndex` and then calls `get_indexer_non_unique()` instead. We should not switch to `get_indexer_non_unique()` for other index levels than overlapping `IntervalIndex`, even though that actually would work as well. That is because `get_indexer_non_unique()` comes with a performance penalty of roughly 30% compared to `get_indexer()`, measured by simple `%timeit` measurements.
johannes-mueller
added a commit
to boschresearch/pandas
that referenced
this issue
Nov 23, 2021
…#44096) `BaseMultiIndexCodesEngine._extract_level_codes` relies on the assumption that `get_indexer()` is always usable as any index level `is_unique`. However, that is not the case for overlapping `IntervalIndex` levels. `get_indexer()` can not be used on an `IntervalIndex` that `is_overlapping` even if it `is_unique`. This patch checks if the index level is an overlapping `IntervalIndex` and then calls `get_indexer_non_unique()` instead. We should not switch to `get_indexer_non_unique()` for other index levels than overlapping `IntervalIndex`, even though that actually would work as well. That is because `get_indexer_non_unique()` comes with a performance penalty of roughly 30% compared to `get_indexer()`, measured by simple `%timeit` measurements.
4 tasks
johannes-mueller
added a commit
to boschresearch/pandas
that referenced
this issue
Nov 23, 2021
…#44096) `BaseMultiIndexCodesEngine._extract_level_codes` relies on the assumption that `get_indexer()` is always usable as any index level `is_unique`. However, that is not the case for overlapping `IntervalIndex` levels. `get_indexer()` can not be used on an `IntervalIndex` that `is_overlapping` even if it `is_unique`. This patch uses `get_indexer_for()` instead.
johannes-mueller
added a commit
to boschresearch/pandas
that referenced
this issue
Nov 24, 2021
…#44096) `BaseMultiIndexCodesEngine._extract_level_codes` relies on the assumption that `get_indexer()` is always usable as any index level `is_unique`. However, that is not the case for overlapping `IntervalIndex` levels. `get_indexer()` can not be used on an `IntervalIndex` that `is_overlapping` even if it `is_unique`. This patch uses `get_indexer_for()` instead.
johannes-mueller
added a commit
to boschresearch/pandas
that referenced
this issue
Nov 25, 2021
…#44096) `BaseMultiIndexCodesEngine._extract_level_codes` relies on the assumption that `get_indexer()` is always usable as any index level `is_unique`. However, that is not the case for overlapping `IntervalIndex` levels. `get_indexer()` can not be used on an `IntervalIndex` that `is_overlapping` even if it `is_unique`. This patch uses `get_indexer_for()` instead.
jreback
pushed a commit
that referenced
this issue
Nov 25, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I have checked that this issue has not already been reported. (might be related to issues with overlapping multi index intervals #27456)
I have confirmed this bug exists on the latest version of pandas.
I have confirmed this bug exists on the master branch of pandas.
Reproducible Example
Issue Description
Joining
idx_1_broken
withidx_2_broken
for no obvious reason. The difference between the_working
and the_broken
indeces is, that in_working
theinterval
level is the same for the twonum
level entries, whereas in_broken
they one limit differs (see comment in the code)Output of the example script:
Expected Behavior
I would expect that the join operation works the same way as for
idx_1_working
andidx_2_working
.Expected output of the scipt:
Installed versions
INSTALLED VERSIONS
commit : 3a6d4cd
python : 3.9.7.final.0
python-bits : 64
OS : Linux
OS-release : 5.4.0-88-lowlatency
Version : #99-Ubuntu SMP PREEMPT Thu Sep 23 18:30:52 UTC 2021
machine : x86_64
processor : x86_64
byteorder : little
LC_ALL : None
LANG : de_DE.UTF-8
LOCALE : de_DE.UTF-8
pandas : 1.4.0.dev0+933.g3a6d4cd01d
numpy : 1.21.2
pytz : 2021.3
dateutil : 2.8.2
pip : 21.2.4
setuptools : 58.0.4
Cython : None
pytest : 6.2.5
hypothesis : 6.23.3
sphinx : None
blosc : None
feather : None
xlsxwriter : None
lxml.etree : None
html5lib : None
pymysql : None
psycopg2 : None
jinja2 : None
IPython : None
pandas_datareader: None
bs4 : None
bottleneck : None
fsspec : None
fastparquet : None
gcsfs : None
matplotlib : None
numexpr : None
odfpy : None
openpyxl : None
pandas_gbq : None
pyarrow : None
pyxlsb : None
s3fs : None
scipy : None
sqlalchemy : None
tables : None
tabulate : None
xarray : None
xlrd : None
xlwt : None
numba : None
The text was updated successfully, but these errors were encountered: