Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: Index == Series should return NotImplemented #36759

Open
jbrockmendel opened this issue Oct 1, 2020 · 1 comment
Open

DEPR: Index == Series should return NotImplemented #36759

jbrockmendel opened this issue Oct 1, 2020 · 1 comment
Labels
Deprecate Functionality to remove in pandas
Milestone
3.0

Comments

@jbrockmendel
Copy link
Member

ATM index == series returns an ndarray because Index.__eq__ does not return NotImplemented. It isn't clear to me what the reason for this is. The special casing leads to a non-trivial amount of complexity in the code and especially in the tests.

We should deprecate this special casing.
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 1, 2020
@jbrockmendel jbrockmendel added Deprecate Functionality to remove in pandas and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 12, 2020
@jbrockmendel jbrockmendel mentioned this issue Oct 16, 2020
Closed
5 tasks
@jreback jreback added this to the 1.2 milestone Nov 9, 2020
@jbrockmendel
Copy link
Member Author

Discussed on Nov 2020 dev call, decided to hold until we have a BoolIndex

@simonjayhawkins simonjayhawkins removed this from the 1.2 milestone Nov 11, 2020
@jbrockmendel jbrockmendel mentioned this issue Dec 20, 2021
Closed
@jbrockmendel jbrockmendel mentioned this issue Jul 14, 2022
Open
8 tasks
@jbrockmendel jbrockmendel mentioned this issue Aug 10, 2023
Open
@jbrockmendel jbrockmendel added this to the 3.0 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

API: Index.__cmp__(Series) return NotImplemented jbrockmendel/pandas
3 participants
@jreback @jbrockmendel @simonjayhawkins