Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: EA/Index/Series.factorize should have same kwargs as pd.factorize #33838

Closed
jbrockmendel opened this issue Apr 28, 2020 · 3 comments
Closed

API: EA/Index/Series.factorize should have same kwargs as pd.factorize #33838

jbrockmendel opened this issue Apr 28, 2020 · 3 comments
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff API Design

Comments

@jbrockmendel
Copy link
Member

This will allow pd.factorize to dispatch to the EA/Index/Series implementations instead of the other way around.
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 28, 2020
@jorisvandenbossche
Copy link
Member

What would be the advantage of having pd.factorize() call Series.factorize() instead of Series.factorize() calling pd.factorize() as it is now?

@jorisvandenbossche jorisvandenbossche removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 28, 2020
@jbrockmendel jbrockmendel reopened this Nov 27, 2020
@jbrockmendel
Copy link
Member Author

Reopening bc I'm finding that having DTI.factorize retain freq is a PITA if I can't just defer to the DTI/DTA implementation

@jbrockmendel
Copy link
Member Author

xref #35563

@mroeschke mroeschke added the Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff label Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff API Design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jorisvandenbossche @jbrockmendel @mroeschke