Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPS: drop numexpr < 2.4.6 #15213

Closed
jreback opened this issue Jan 24, 2017 · 2 comments
Closed

DEPS: drop numexpr < 2.4.6 #15213

jreback opened this issue Jan 24, 2017 · 2 comments
Assignees
@FrancescAlted
Labels
Compat pandas objects compatability with Numpy or Python functions Dependencies Required and optional dependencies
Milestone
0.20.0

Comments

@jreback
Copy link
Contributor

jreback commented Jan 24, 2017 •
edited
Loading

since 2.4.4 is specifically exluded because of some multi-threading issues, this eliminates the pandas checks for this (as well as some compat code for earlier versions of numexpr).
@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Jan 24, 2017
@jreback jreback added this to the 1.0 milestone Jan 24, 2017
@jreback
Copy link
Contributor Author

jreback commented Jan 24, 2017

cc @FrancescAlted

@jreback jreback changed the title COMPAT: drop numexpr < 2.4.6 DEPS: drop numexpr < 2.4.6 Jan 28, 2017
@jreback jreback added the Dependencies Required and optional dependencies label Jan 28, 2017
@FrancescAlted FrancescAlted self-assigned this Jan 29, 2017
@FrancescAlted
Copy link

Yep. I strongly suggest that to use newest 2.6.2 version that I just released. It fixes several issues and adds initial support for the POWER architecture. I can provide a PR for this.

This was referenced Feb 13, 2017
Closed
Closed
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, 1.0 Mar 2, 2017
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
@AnkurDedania
BLD: Numexpr 2.4.6 required
49f0c75 
closes pandas-dev#15213

Author: Francesc Alted <francesc@continuum.io>

Closes pandas-dev#15383 from FrancescAlted/numexpr-2.4.6 and squashes the following commits:

c417fe2 [Francesc Alted] Simplify and remove UserWarning testing on numexpr import
e1b34a9 [Francesc Alted] Force a reload of pd.computation for actually triggering the UserWarning
c081199 [Francesc Alted] Relax the exact message for the ImportError
73f0319 [Francesc Alted] numexpr requisite raised to 2.4.6
0d4ab9a [Francesc Alted] Restored the old numexpr version dependencies to adjust for old requirements
c1aae19 [Francesc Alted] Fixed a lint error
7575ba2 [Francesc Alted] Using constants instead of literals for numexpr version
7a275ce [Francesc Alted] Fixed a typo
93f54aa [Francesc Alted] numexpr section moved to Other API changes section
3b6e58b [Francesc Alted] Removed recomendation for numexpr 2.6.2
f225598 [Francesc Alted] Updated test_compat for numexpr 2.4.6
8bd4ed1 [Francesc Alted] numexpr 2.4.6 requirement moved to other enhancements section
e45b742 [Francesc Alted] Moved pinned versions in CI folder to 2.4.6
6e12e29 [Francesc Alted] Added a notice on the recommended numexpr version
ac62653 [Francesc Alted] Require numexpr 2.4.6
ab79c54 [Francesc Alted] Require numexpr 2.6.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrancescAlted FrancescAlted

Labels
Compat pandas objects compatability with Numpy or Python functions Dependencies Required and optional dependencies
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

Require numexpr 2.6.2 FrancescAlted/pandas
Numexpr 2.4.6 FrancescAlted/pandas
3 participants
@FrancescAlted @jreback @jorisvandenbossche