Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy 1.7.1 and fix #827 #829

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Mypy 1.7.1 and fix #827 #829

merged 2 commits into from
Dec 18, 2023

Conversation

twoertwein
Copy link
Member

xref #826: install mypy 1.7.1 and add test for Series. Index is complicated: needs to be Self for sub-classes but Self seems to indicate Index[Never/nothing] for mypy.

@twoertwein
Copy link
Member Author

It might be good to have a new release soon.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @twoertwein

@Dr-Irv Dr-Irv merged commit afb0db5 into pandas-dev:main Dec 18, 2023
10 checks passed
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Dec 18, 2023

It might be good to have a new release soon.

Thanks for the suggestion. I did a v2.1.4.231218 release today that included your changes, bumps up the pandas version and the pyright version to 1.1.341 .

@twoertwein twoertwein deleted the mypy branch February 10, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

 Type "NaTType" is not hashable
2 participants