GH1246 Upgrade to pandas 2.3.0 #1247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicdiridollou
commented
Jun 10, 2025
tests/test_frame.py
Outdated
| "DataFrameGroupBy.apply operated on the grouping columns.", | ||
| upper="2.2.99", | ||
| ), | ||
| pytest_warns_bounded( |
There was a problem hiding this comment.
Quite annoying that they changed the type of warning that was raised but guess we don't have too much choice than doubling the context manager to grab the warnings.
There was a problem hiding this comment.
We are testing with 2.3, so you only need to test for FutureWarning with upper="2.3.99"
|
/pandas_nightly |
Dr-Irv
requested changes
Jun 10, 2025
tests/__init__.py
Outdated
| @@ -50,6 +50,7 @@ | |||
|
|
|||
| TYPE_CHECKING_INVALID_USAGE: Final = TYPE_CHECKING | |||
| WINDOWS = os.name == "nt" or "cygwin" in platform.system().lower() | |||
| PD_LTE_23 = Version(pd.__version__) < Version("2.3.999") | |||
| PD_LTE_22 = Version(pd.__version__) < Version("2.2.999") | |||
There was a problem hiding this comment.
should remove the PD_LTE_22
tests/test_frame.py
Outdated
| "DataFrameGroupBy.apply operated on the grouping columns.", | ||
| upper="2.2.99", | ||
| ), | ||
| pytest_warns_bounded( |
There was a problem hiding this comment.
We are testing with 2.3, so you only need to test for FutureWarning with upper="2.3.99"
tests/test_frame.py
Outdated
Comment on lines
3471
to
3476
| with ( | ||
| pytest_warns_bounded( | ||
| DeprecationWarning, | ||
| "DataFrameGroupBy.apply operated on the grouping columns.", | ||
| upper="2.2.99", | ||
| ), |
tests/test_frame.py
Outdated
| pytest_warns_bounded( | ||
| FutureWarning, | ||
| "DataFrameGroupBy.apply operated on the grouping columns.", | ||
| lower="2.2.99", |
tests/test_frame.py
Outdated
Comment on lines
3488
to
3499
| with ( | ||
| pytest_warns_bounded( | ||
| DeprecationWarning, | ||
| "DataFrameGroupBy.apply operated on the grouping columns.", | ||
| upper="2.2.99", | ||
| ), | ||
| pytest_warns_bounded( | ||
| FutureWarning, | ||
| "DataFrameGroupBy.apply operated on the grouping columns.", | ||
| lower="2.2.99", | ||
| upper="2.3.99", | ||
| ), |
There was a problem hiding this comment.
same comment - just leave in the 2.3 test since that is all we are testing against
tests/test_frame.py
Outdated
Comment on lines
4430
to
4434
| DeprecationWarning, | ||
| msg, | ||
| lower="2.2.99", | ||
| upper="2.2.99", | ||
| ): |
There was a problem hiding this comment.
since no warning is issued with 2.3, we can just leave out the context manager
tests/test_groupby.py
Outdated
Comment on lines
81
to
90
| pytest_warns_bounded( | ||
| DeprecationWarning, | ||
| "DataFrameGroupBy.(apply|resample) operated on the grouping columns", | ||
| upper="2.2.99", | ||
| ), | ||
| pytest_warns_bounded( | ||
| FutureWarning, | ||
| "DataFrameGroupBy.(apply|resample) operated on the grouping columns", | ||
| lower="2.2.99", | ||
| upper="2.3.99", |
There was a problem hiding this comment.
only include the FutureWarning
tests/test_groupby.py
Outdated
Comment on lines
135
to
146
| with ( | ||
| pytest_warns_bounded( | ||
| DeprecationWarning, | ||
| "DataFrameGroupBy.(apply|resample) operated on the grouping columns", | ||
| upper="2.2.99", | ||
| ), | ||
| pytest_warns_bounded( | ||
| FutureWarning, | ||
| "DataFrameGroupBy.(apply|resample) operated on the grouping columns", | ||
| lower="2.2.99", | ||
| upper="2.3.99", | ||
| ), |
tests/test_groupby.py
Outdated
Comment on lines
192
to
201
| pytest_warns_bounded( | ||
| DeprecationWarning, | ||
| "DataFrameGroupBy.(apply|resample) operated on the grouping columns", | ||
| upper="2.2.99", | ||
| ), | ||
| pytest_warns_bounded( | ||
| FutureWarning, | ||
| "DataFrameGroupBy.(apply|resample) operated on the grouping columns", | ||
| lower="2.2.99", | ||
| upper="2.3.99", |
tests/test_groupby.py
Outdated
Comment on lines
216
to
227
| with ( | ||
| pytest_warns_bounded( | ||
| DeprecationWarning, | ||
| "DataFrameGroupBy.(apply|resample) operated on the grouping columns", | ||
| upper="2.2.99", | ||
| ), | ||
| pytest_warns_bounded( | ||
| FutureWarning, | ||
| "DataFrameGroupBy.(apply|resample) operated on the grouping columns", | ||
| lower="2.2.99", | ||
| upper="2.3.99", | ||
| ), |
|
actually the nightly run did happen. So make sure it is OK as well. See https://github.com/pandas-dev/pandas-stubs/actions/runs/15561066263/job/43813216242 |
|
/pandas_nightly |
|
https://github.com/pandas-dev/pandas-stubs/actions/runs/15586088519 |
Dr-Irv
requested changes
Jun 11, 2025
tests/test_frame.py
Outdated
Comment on lines
1545
to
1559
| with pytest_warns_bounded( | ||
| FutureWarning, | ||
| "(The provided callable <built-in function sum> is currently using|The behavior of DataFrame.sum with)", | ||
| upper="2.2.99", | ||
| ): | ||
| with pytest_warns_bounded( | ||
| DeprecationWarning, | ||
| "DataFrameGroupBy.apply operated on the grouping columns", | ||
| upper="2.2.99", | ||
| ): | ||
| if PD_LTE_22: | ||
| check( | ||
| assert_type(df.groupby(by="col1").apply(sum), pd.DataFrame), | ||
| pd.DataFrame, | ||
| ) |
There was a problem hiding this comment.
This test needs to remain, but use 2 FutureWarning with upper="2.3.99" and have a check on PD_LTE_23
tests/test_frame.py
Outdated
Comment on lines
3437
to
3438
| lower="2.2.99", | ||
| upper="2.3.99", |
tests/test_frame.py
Outdated
Comment on lines
3449
to
3450
| lower="2.2.99", | ||
| upper="2.99.99", |
tests/test_frame.py
Outdated
Comment on lines
3460
to
3461
| lower="2.2.99", | ||
| upper="2.3.99", |
tests/test_frame.py
Outdated
Comment on lines
3471
to
3472
| lower="2.2.99", | ||
| upper="2.3.99", |
tests/test_frame.py
Outdated
| msg = "The copy keyword is deprecated and will be removed in a future" | ||
| with pytest_warns_bounded( | ||
| DeprecationWarning, | ||
| msg, | ||
| lower="2.2.99", | ||
| lower="2.3.99", | ||
| upper="3.0.0", |
tests/test_groupby.py
Outdated
Comment on lines
83
to
84
| lower="2.2.99", | ||
| upper="2.3.99", |
tests/test_groupby.py
Outdated
Comment on lines
131
to
132
| lower="2.2.99", | ||
| upper="2.3.99", |
tests/test_groupby.py
Outdated
Comment on lines
180
to
181
| lower="2.2.99", | ||
| upper="2.3.99", |
tests/test_groupby.py
Outdated
Comment on lines
198
to
199
| lower="2.2.99", | ||
| upper="2.3.99", |
|
/pandas_nightly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value