Updating Debian Package - Installation Paths#1564
Open
AndrewQuijano wants to merge 3 commits intodevfrom
Open
Conversation
AndrewQuijano
changed the title
AndrewQuijano
force-pushed
the
updated-debian
branch
2 times, most recently
from
91d45aa to
1dc116c
Compare
AndrewQuijano
changed the title
AndrewQuijano
force-pushed
the
updated-debian
branch
5 times, most recently
from
8928d13 to
3be241a
Compare
AndrewQuijano
changed the title
AndrewQuijano
force-pushed
the
updated-debian
branch
2 times, most recently
from
78bf34c to
c83a33a
Compare
AndrewQuijano
force-pushed
the
updated-debian
branch
3 times, most recently
from
8b5904b to
de4ef40
Compare
AndrewQuijano
force-pushed
the
updated-debian
branch
2 times, most recently
from
3b76e6c to
17d1b86
Compare
AndrewQuijano
changed the title
AndrewQuijano
changed the title
AndrewQuijano
changed the title
AndrewQuijano
force-pushed
the
updated-debian
branch
from
17d1b86 to
980edb7
Compare
AndrewQuijano
changed the title
AndrewQuijano
force-pushed
the
updated-debian
branch
2 times, most recently
from
791ea0d to
ddf1efe
Compare
AndrewQuijano
force-pushed
the
updated-debian
branch
from
ddf1efe to
7435ef7
Compare
AndrewQuijano
force-pushed
the
updated-debian
branch
from
7435ef7 to
e53c7ff
Compare
AndrewQuijano
force-pushed
the
updated-debian
branch
from
e53c7ff to
07e7271
Compare
github-actions
Bot
added
pypanda
AndrewQuijano
changed the title
AndrewQuijano
force-pushed
the
updated-debian
branch
from
07e7271 to
96236a4
Compare
github-actions
Bot
added
Build
Github-files
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Debian package installation paths from /usr/local to /usr to comply with Debian policy (FHS mandates packages not place files in /usr/local), and fixes the documentation CI/CD workflow to skip pushing when there are no changes.
Changes:
- Modified C code and Python code to dynamically detect whether PANDA is installed via Debian package (in
/usr) or traditional install (in/usr/local) - Updated Dockerfile to parameterize installation prefix and prepare for Debian packaging with correct paths
- Fixed documentation workflow to check for changes before committing
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| panda/src/callbacks.c | Added dynamic path detection logic to set INSTALL_BIN_DIR and INSTALL_PLUGIN_DIR based on presence of panda binaries in /usr/bin |
| panda/python/core/pandare/utils.py | Added /usr/bin/ to the list of potential build directories to check for Debian installations |
| panda/python/core/pandare/panda.py | Added plugin path resolution for Debian installations at /usr/lib/panda |
| panda/plugins/osi_linux/osi_linux.cpp | Added fallback search path for kernelinfo.conf at /etc/panda/osi_linux for Debian packages |
| Dockerfile | Parameterized installation prefix with INSTALL_PREFIX ARG and updated packager stage to copy files to correct Debian paths (/usr instead of /usr/local) |
| .github/workflows/publish_docker.yml | Added check to skip git commit/push when no documentation changes are detected |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AndrewQuijano
force-pushed
the
updated-debian
branch
from
ab9ca5b to
5447c97
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AndrewQuijano
force-pushed
the
updated-debian
branch
2 times, most recently
from
e99cfca to
69942a7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AndrewQuijano
force-pushed
the
updated-debian
branch
from
69942a7 to
ddb39cd
Compare
…ckaging standards
AndrewQuijano
force-pushed
the
updated-debian
branch
from
ddb39cd to
89fd67c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request is to close #1605
The two main changes are:
Debian packages, as shown in the issue, shouldn't install to /usr/local but /usr; this has been updated. Relevant changes to avoid breaking PANDA were made, too.
Quick fix on documentation CI/CD, if no Python code changes, it shouldn't error out if there is no change to the pypanda documentation.