Skip to content

Commit

Permalink
introduce and use qemu_clock_enable
Browse files Browse the repository at this point in the history
By adding the possibility to turn on/off a clock, yet another
incestuous relationship between timers and CPUs can be disentangled.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
  • Loading branch information
bonzini authored and Anthony Liguori committed Mar 17, 2010
1 parent 8c04ba5 commit 972abbe
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions vl.c
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,7 @@ void cpu_disable_ticks(void)

struct QEMUClock {
int type;
int enabled;
/* XXX: add frequency */
};

Expand Down Expand Up @@ -812,9 +813,15 @@ static QEMUClock *qemu_new_clock(int type)
QEMUClock *clock;
clock = qemu_mallocz(sizeof(QEMUClock));
clock->type = type;
clock->enabled = 1;
return clock;
}

static void qemu_clock_enable(QEMUClock *clock, int enabled)
{
clock->enabled = enabled;
}

QEMUTimer *qemu_new_timer(QEMUClock *clock, QEMUTimerCB *cb, void *opaque)
{
QEMUTimer *ts;
Expand Down Expand Up @@ -907,6 +914,9 @@ static void qemu_run_timers(QEMUClock *clock)
{
QEMUTimer **ptimer_head, *ts;
int64_t current_time;

if (!clock->enabled)
return;

current_time = qemu_get_clock (clock);
ptimer_head = &active_timers[clock->type];
Expand Down Expand Up @@ -1017,8 +1027,7 @@ static void qemu_run_all_timers(void)

/* vm time timers */
if (vm_running) {
if (!cur_cpu || likely(!(cur_cpu->singlestep_enabled & SSTEP_NOTIMER)))
qemu_run_timers(vm_clock);
qemu_run_timers(vm_clock);
}

qemu_run_timers(rt_clock);
Expand Down Expand Up @@ -3969,6 +3978,9 @@ static void tcg_cpu_exec(void)
for (; next_cpu != NULL; next_cpu = next_cpu->next_cpu) {
CPUState *env = cur_cpu = next_cpu;

qemu_clock_enable(vm_clock,
(cur_cpu->singlestep_enabled & SSTEP_NOTIMER) == 0);

if (alarm_timer->pending)
break;
if (cpu_can_run(env))
Expand Down

0 comments on commit 972abbe

Please sign in to comment.