Skip to content

Commit

Permalink
balloon: Simplify code flow
Browse files Browse the repository at this point in the history
Replace:
  if (foo) {
    ...
  } else {
    return 0;
  }

by

  if (!foo) {
    return 0;
  }
  ...

Signed-off-by: Amit Shah <amit.shah@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
  • Loading branch information
amit3s authored and Anthony Liguori committed Aug 4, 2011
1 parent b80bc1d commit 182b920
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions balloon.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,23 +42,21 @@ void qemu_add_balloon_handler(QEMUBalloonEvent *func, void *opaque)

static int qemu_balloon(ram_addr_t target, MonitorCompletion cb, void *opaque)
{
if (balloon_event_fn) {
trace_balloon_event(balloon_opaque, target);
balloon_event_fn(balloon_opaque, target, cb, opaque);
return 1;
} else {
if (!balloon_event_fn) {
return 0;
}
trace_balloon_event(balloon_opaque, target);
balloon_event_fn(balloon_opaque, target, cb, opaque);
return 1;
}

static int qemu_balloon_status(MonitorCompletion cb, void *opaque)
{
if (balloon_event_fn) {
balloon_event_fn(balloon_opaque, 0, cb, opaque);
return 1;
} else {
if (!balloon_event_fn) {
return 0;
}
balloon_event_fn(balloon_opaque, 0, cb, opaque);
return 1;
}

static void print_balloon_stat(const char *key, QObject *obj, void *opaque)
Expand Down

0 comments on commit 182b920

Please sign in to comment.