fix: Items unique key warning in dropdown menu to avoid rerenders #10925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the functionality of the
DropdownMenu
component by improving click handling and refactoring event handlers for better readability and maintainability.Detailed summary
handleClick
andhandleExternalClick
functions to manage click events.onClick
handlers inMenuItem
with the new functions.handlePointerDown
for toggling the dropdown state.MenuItem
mapping for better uniqueness.