Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use isAddressEqual for comparison #10916

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Nov 6, 2024


PR-Codex overview

This PR focuses on replacing direct address comparisons with the isAddressEqual utility function across various components and hooks in the codebase to improve address comparison consistency and maintainability.

Detailed summary

  • Updated TripleLogo.tsx to use isAddressEqual for address comparison.
  • Modified StablePoolPage to replace address checks with isAddressEqual.
  • Changed AccessRiskComponent to utilize isAddressEqual.
  • Altered useMerkl.tsx to implement isAddressEqual for token address checks.
  • Updated GasTokenSelector to use isAddressEqual for gas token comparisons.
  • Refactored useSwapInputError.ts to use isAddressEqual in address checks.
  • Changed useEstimatedAmount.ts to utilize isAddressEqual for token comparisons.
  • Updated SwapModalFooter and SwapModalFooterV2 to use isAddressEqual for address checks.
  • Refactored Step1.tsx in the Migration component to replace address comparisons with isAddressEqual.
  • Updated address checks in [[...currency]].tsx using isAddressEqual.
  • Changed AddStableLiquidity/index.tsx to use isAddressEqual for token order checks.
  • Refactored address comparisons in hooks.ts to utilize isAddressEqual.
  • Updated address filtering in FixedStaking/index.tsx with isAddressEqual.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 11:52am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 11:52am
blog ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 11:52am
bridge ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 11:52am
games ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 11:52am
gamification ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 11:52am
uikit ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 11:52am

Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: bdf2c09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@memoyil memoyil force-pushed the feature/chore_use_isaddressequal_for_comparison branch from 82c71a6 to 13e6a45 Compare November 6, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant