Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cross chain sync not handling insufficent balance and user reject #10321

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Aug 5, 2024


PR-Codex overview

This PR focuses on enhancing the CrossChainVeCakeModal component by adding better state management for insufficient balance and integrating a WarningIcon for user feedback.

Detailed summary

  • Added setIsOpen prop to the CrossChainVeCakeModal component.
  • Updated useCatchTxError to throw user reject errors.
  • Expanded modalState to include 'insufficent'.
  • Improved balance check logic with a new state for insufficient funds.
  • Integrated WarningIcon for insufficient balance notifications.
  • Modified ReadyToSyncView to accept modalState as a prop for conditional rendering.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 7:43am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:43am
blog ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:43am
bridge ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:43am
games ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:43am
gamification ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:43am
uikit ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:43am

Copy link

changeset-bot bot commented Aug 5, 2024

⚠️ No Changeset found

Latest commit: a49a33b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant