Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[MINOR][SQL] Remove
toLowerCase(Locale.ROOT)
for `CATALOG_IMPLEMENT…
…ATION` ### What changes were proposed in this pull request? This PR aims to remove redundant `toLowerCase(Locale.ROOT)` transforms during checking `CATALOG_IMPLEMENTATION` values. ### Why are the changes needed? We already have `checkValues`. https://github.com/apache/spark/blob/9d9675922543e3e5c3b01023e5a756462a1fd308/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala#L52 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Manually I checked the following. I believe these are all occurrences. ``` $ git grep -C1 '.toLowerCase(Locale.ROOT)' | grep '"hive' repl/src/main/scala/org/apache/spark/repl/Main.scala- .get(CATALOG_IMPLEMENTATION.key, "hive") repl/src/main/scala/org/apache/spark/repl/Main.scala: .toLowerCase(Locale.ROOT) == "hive") { sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala: jsc.sc.conf.get(CATALOG_IMPLEMENTATION.key, "hive").toLowerCase(Locale.ROOT) == sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala- "hive" && sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSchemaInferenceSuite.scala- provider = Option("hive"), ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45184 from dongjoon-hyun/SPARK_CATALOG_IMPLEMENTATION. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
- Loading branch information