Fixed type issue #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ettings in parent tsconfig.
> ts-gems@3.5.1 compile
> tsc -b tsconfig.json
tsconfig.json:5:15 - error TS5110: Option 'module' must be set to 'Node16' when option 'moduleResolution' is set to 'Node16'.
5 "module": "CommonJS",
~~~~~~~~~~
npm run build tsc node_modules/strict-typed-events/node_modules/ts-gems/lib/types.d.ts:21:17 - error TS2304: Cannot find name 'ReadableStreamGetReaderOptions'. 21 options?: ReadableStreamGetReaderOptions, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ node_modules/strict-typed-events/node_modules/ts-gems/lib/types.d.ts:22:8 - error TS2552: Cannot find name 'ReadableStreamReader'. Did you mean 'ReadableStream'? 22 ): ReadableStreamReader; ~~~~~~~~~~~~~~~~~~~~ Found 2 errors in the same file, starting at: node_modules/strict-typed-events/node_modules/ts-gems/lib/types.d.ts:21
Closed
|
Adding reference to dom library fixed the issue. No need this implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution to the Type issue when not using dom. Had to change the tsconfig to match the parent version in order to make it compile on node 22. Not sure if you rather change the parent.