-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the PowerDNS-Admin API #15
base: master
Are you sure you want to change the base?
Add support for the PowerDNS-Admin API #15
Conversation
This is pretty much functionally identical to #10 but works for all API roles in PowerDNS-Admin |
For some reason the build fails after pushing an update to README.md. This is most likely a false positive, but please let me know if you need anything to get this merged. :-) |
80a9b4f
to
19b142d
Compare
Updated the PR as I saw reverse proxy configurations changing the default gunicorn HTTP Status messages from eg. "FORBIDDEN" to "Forbidden" to better honor the RFCs. I have redone the check to use the status_code, which makes more sense since the textual representation is just another representation of the code anyway. |
153cf17
to
59235e1
Compare
59235e1
to
a281298
Compare
I can confirm that this change makes it work with the PowerDNS-Admin API. Thanks! |
Any Updates on this PR? |
Hi, we encountered the same error when using the PowerDNS Admin API and I'm glad to found that someone encountered the same issue. It will be really amazing if someone from @pan-net-security could take a quick look and merge it. Sorry for the mention but maybe @splashx @beli-sk @mbag @matusf can help us with this. Thanks in advance! |
FWIW, I'm still using the same code in production in several places, with no issue since this PR was created. |
I also know that we're able to manually build it or whatever, but as this project has the |
The PowerDNS-Admin project provides a PowerDNS compatible API that's scoped to allow an API KEY to access only specific, authenticated domains.
The only change needed to support this in certbot-dns-powerdns, is to accept a few new responses when guessing the zone name.
This PR adds support for this, and have been tested with all (3) available access roles from PowerDNS-Admin (User, Operator, Administrator).