Fix unexpected argument splitting

[simark]

This doesn't work:

$ isolate-gpu -d 2 ./gdb -nx -q --data-directory=data-directory testsuite/outputs/gdb.rocm/simple/simple -ex "with breakpoint pending on -- break do_an_addition"
Excess command line arguments ignored. (pending ...)
Reading symbols from testsuite/outputs/gdb.rocm/simple/simple...
/home/smarchi/build/binutils-gdb-amd-staging/gdb/breakpoint: No such file or directory.
Missing arguments.
(gdb)

The argument "with breakpoint ..." gets split along the way. Fix it by using bash-specific array substitution to avoid it. Arrays are a bash specific feature, so change the shebang to bash (which IMO is fine, it's rare not to have bash installed).

Change the "else" portion just to match the style of the "if" section.

With this patch, I get the expected:

$ isolate-gpu -d 2 ./gdb -nx -q --data-directory=data-directory testsuite/outputs/gdb.rocm/simple/simple -ex "with breakpoint pending on -- break do_an_addition"
Reading symbols from testsuite/outputs/gdb.rocm/simple/simple...
Function "do_an_addition" not defined.
Breakpoint 1 (do_an_addition) pending.
(gdb)

[simark]

Also, regarding the use of bash: it is already used in entrypoint.sh.

[palves]

Thanks for the patch. Definitely a "doh" on my end to use "$*" here. A couple comments.

[palves]

Also, regarding the use of bash: it is already used in entrypoint.sh.

But it isn't? I guess you really meant isolate-gpu.

[simark]

Also, regarding the use of bash: it is already used in entrypoint.sh.

But it isn't? I guess you really meant isolate-gpu.

Yeah that's what I meant.

[simark]

Force pushed.

[palves]

Merged, released, and pushed to docker hub. Thanks!