Added to NullEle doc. #104
Conversation
source/element-kinds.md
Outdated
|
|
||
| Placeholder element used for bookkeeping. | ||
| Placeholder element used for bookkeeping when constructing the expanded lattice. | ||
| This element can be used as a reference element for superpositions. |
There was a problem hiding this comment.
This sentence is not clear to me. How is this different to a Marker?
There was a problem hiding this comment.
Sorry I left out the important sentence "NullEle elements will be removed from the expanded lattice."
There was a problem hiding this comment.
Got it.
I mean, This element can be used as a reference element for superpositions. is not clear to me / too brief for me. How is this different to a Marker?
There was a problem hiding this comment.
Yes markers can be used but then markers are not removed in the expanded lattice and sometimes this is not desired.
There was a problem hiding this comment.
Got it, so we want to use this mostly for internal representation jobs.
I think APIs should add .filter() functions to remove any desired element by name/kind/attribute, will note for our reference implementation.
There was a problem hiding this comment.
My concept of NullEle is very limited.
There was a problem hiding this comment.
Ok, then let me merge in a bit what we need an empty element for.
There was a problem hiding this comment.
Updated.
Unfortunately, as a reference element for superpositions. still is not clear to me and needs more description.
- What is meant by this sentence? Can you help me understand this with a workflow description/example?
- Why would one not use a
Markerfor reference points, I would assume one wants to name any reference point propertly?
There was a problem hiding this comment.
Hmmm. So in PALS the reference element is called base_item. I have changed the text to reflect this.
Sometimes someone will not want the finished lattice cluttered up with a bunch of markers that are rather arbitrarily placed to do superposition.
There was a problem hiding this comment.
Thank you, ah that is the mental reference that was lacking. Let me read up the link and come back :)
|
The |
|
@ax3l Please do not push changes to the PR without consulting me first since when I am making changes at the same time Git will become unhappy and then I have to spend time sorting everything out. |
|
Oh sorry for the direct commit, will use suggestions to keep it clearer 👍 |
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
Reads well, thanks for the iterations together!
No description provided.