Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserve invalid itms-services url scheme #2695

Merged
merged 1 commit into from
May 6, 2023
Merged

preserve invalid itms-services url scheme #2695

merged 1 commit into from
May 6, 2023

Conversation

davidism
Copy link
Member

@davidism davidism commented May 6, 2023

Partially revert #2609. The iri_to_uri safe_conversion parameter is still deprecated. redirect no longer calls iri_to_uri, the only time the check is done is in Response.to_wsgi_headers. In 2.4, that should become a flag like response.process_location or normalize_location so that the exception and split aren't needed.

fixes #2691

@davidism davidism added this to the 2.3.4 milestone May 6, 2023
@davidism davidism merged commit 5a149fa into 2.3.x May 6, 2023
@davidism davidism deleted the location-uri branch May 6, 2023 15:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.
1 participant
@davidism