Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add specific supported python versions to classifiers metadata #2528

Closed
wants to merge 2 commits into from

Conversation

fmigneault
Copy link

I would like to propose this simple metadata update.

Multiple tools like https://pyup.io, https://requires.io, etc. parse this package metadata to indicate whether they support specific versions and environments. Because werkzeug does not indicate them explicitly, they are flagged as incompatible for Python 3, although the docs and other configurations report that python_requires = >= 3.7.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism
Copy link
Member

davidism commented Oct 5, 2022

Those tools should check python_requires instead (or additionally). It specifies that all versions >= 3.7 are supported (as long as that version of Werkzeug is also supported). Maintaining classifiers doesn't work because it requires a new release of Werkzeug to indicate "support" for a new release of Python, even if no changes are required for that support.

Please open feature requests to support requires-python metadata on those tools instead.

@davidism davidism closed this Oct 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants