Fix callback order for nested blueprints #4230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pgjones can you check this? Seems to go against the discussion of |
|
I can't remember the details of the discussion that led to the current order. I do think before-functions going from app down and after-functions going from app up makes more sense though. |
davidism
force-pushed
the
blueprint-fix
branch
from
033efee
to
a98ee7e
Compare
Handlers registered via url_value_preprocessor, before_request, context_processor, and url_defaults are called in downward order: First on the app and last on the current blueprint. Handlers registered via after_request and teardown_request are called in upward order: First on the current blueprint and last on the app.
davidism
force-pushed
the
blueprint-fix
branch
from
a98ee7e
to
f8e4dc3
Compare
avoid building nested chain iterables avoid triggering defaultdict when looking up registries apply functions as they are looked up
davidism
force-pushed
the
blueprint-fix
branch
from
f8e4dc3
to
3f6cdbd
Compare
|
I added a changelog, rebased this to 2.0.x, and did a bit more refactoring. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.