specialize progressbar(length=...) as ProgressBar[int] #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
force-pushed
the
progressbar-length-overload
branch
from
b0a8bf9
to
cf0477f
Compare
asottile
force-pushed
the
progressbar-length-overload
branch
from
cf0477f
to
0b3472c
Compare
asottile
commented
Nov 7, 2023
Comment on lines
+14
to
+15
| def it() -> tuple[str, ...]: | ||
| return ("hello", "world") |
There was a problem hiding this comment.
this separate function is entirely so pyright doesn't inference as Literal[("hello", "world")]
asottile
force-pushed
the
progressbar-length-overload
branch
from
0b3472c
to
0f03c96
Compare
davidism
approved these changes
Nov 8, 2023
|
I hate being that guy but I noticed this PR sticking around when I went to clean up some repos -- is there anything left here? |
|
It's good, just haven't had a chance to go through the click backlog in quite a while. |
AndreasBackx
force-pushed
the
progressbar-length-overload
branch
3 times, most recently
from
7660093
to
6045327
Compare
AndreasBackx
force-pushed
the
progressbar-length-overload
branch
from
6045327
to
45fe59f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.