-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new method for choice fail #2622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a fine choice. Could you follow through with the rest of the checklist like documentation and tests?
327e06e
to
0fb1d4c
Compare
I did my best to complete the checkboxes. Notes:
|
Co-authored-by: Andreas Backx <AndreasBackx@users.noreply.github.com>
0fb1d4c
to
723b0c4
Compare
@antazoey thanks for getting back so quickly and my apologies for taking another week myself. I've wrapped it up and merged it, thank you for this fix! |
Refactors so the failing happens in a new public method.
click.types.Choice
#2621Ensure each step in CONTRIBUTING.rst is complete by adding an "x" to
each box below.
If only docs were changed, these aren't relevant and can be removed.
-->
Checklist:
CHANGES.rst
summarizing the change and linking to the issue... versionchanged::
entries in any relevant code docs.pre-commit
hooks and fix any issues.pytest
andtox
, no tests failed.