Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up parameters intro. #2585

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

Rowlando13
Copy link
Collaborator

Made the Parameters' first few sections cleaner and more concise.

@Rowlando13 Rowlando13 marked this pull request as draft August 12, 2023 07:58
@Rowlando13 Rowlando13 marked this pull request as ready for review August 12, 2023 23:45
Copy link

@tachyondecay tachyondecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall—some of the lines aren’t wrapped, not sure how much this matters.

docs/parameters.rst Outdated Show resolved Hide resolved
docs/parameters.rst Outdated Show resolved Hide resolved
@Rowlando13
Copy link
Collaborator Author

Fixed as @tachyondecay suggested. I generally don't split rst files at the 80 character limit since you can just use the text wrap setting. Documentation is long form writing so 80 characters does not make a lot of sense.

@davidism davidism added the docs label Sep 1, 2023
@Rowlando13 Rowlando13 merged commit 9aeb586 into pallets:stable Oct 30, 2024
@Rowlando13 Rowlando13 deleted the rewrite_params_section branch October 30, 2024 00:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants