Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 750 #1333

Merged
merged 1 commit into from
May 31, 2019
Merged

Issue 750 #1333

merged 1 commit into from
May 31, 2019

Conversation

jayg-ts
Copy link
Contributor

@jayg-ts jayg-ts commented May 31, 2019

Updated the example code in the Custom Types example. Given the choice to either force the value to string or return a TypeError in case of a bad type, opted for the latter so that future readers would not assume from the example that defaults have to be type string.

Error is now:

Error: Invalid value for "--val" / "-v": expected string for int() conversion, got 0 of type int

...rather than a stack trace.

closes #750

@jayg-ts jayg-ts changed the base branch from master to 7.x May 31, 2019 19:49
@davidism davidism merged commit 0f84f11 into pallets:7.x May 31, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants