Skip to content

Fix init & multiple app issues with SQLAlchemy interface #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rsyring wants to merge 2 commits into from
Closed

Fix init & multiple app issues with SQLAlchemy interface #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25942e8
remove call to db.create_all() in SqlAlchemySessionInterface
rsyring Jun 11, 2015
1c1f790
prevent multiple models from being created
rsyring Jun 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions flask_session/sessions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,24 +439,27 @@ def __init__(self, app, db, table, key_prefix, use_signer=False):
self.key_prefix = key_prefix
self.use_signer = use_signer

class Session(self.db.Model):
__tablename__ = table
if table not in self.db.metadata:

id = self.db.Column(self.db.Integer, primary_key=True)
session_id = self.db.Column(self.db.String(256), unique=True)
data = self.db.Column(self.db.Text)
expiry = self.db.Column(self.db.DateTime)
class Session(self.db.Model):
__tablename__ = table

def __init__(self, session_id, data, expiry):
self.session_id = session_id
self.data = data
self.expiry = expiry
id = self.db.Column(self.db.Integer, primary_key=True)
session_id = self.db.Column(self.db.String(256), unique=True)
data = self.db.Column(self.db.Text)
expiry = self.db.Column(self.db.DateTime)

def __repr__(self):
return '<Session data %s>' % self.data
def __init__(self, session_id, data, expiry):
self.session_id = session_id
self.data = data
self.expiry = expiry

self.db.create_all()
self.sql_session_model = Session
def __repr__(self):
return '<Session data %s>' % self.data
Copy link
Contributor

@fengsp fengsp Apr 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When should the table be created?


self.sql_session_model = db.session_ext_session_model = Session
else:
Copy link
Contributor

@fengsp fengsp Apr 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we don't need the else?

self.sql_session_model = db.session_ext_session_model

def open_session(self, app, request):
sid = request.cookies.get(app.session_cookie_name)
Expand Down