Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: pylibmc expect time as delta time #153

Merged
merged 3 commits into from
May 31, 2020

Conversation

zoltan-fedor
Copy link
Contributor

Pylibmc expect the timeout to be provided as "number of seconds until the key expire", see http://sendapatch.se/projects/pylibmc/reference.html#pylibmc.Client.set

See more at #152

Pylibmc expect the timeout to be provided as "number of seconds until the key expire", see http://sendapatch.se/projects/pylibmc/reference.html#pylibmc.Client.set
@coveralls
Copy link

coveralls commented Dec 24, 2019

Coverage Status

Coverage decreased (-0.6%) to 79.373% when pulling 21853c5 on zoltan-fedor:master into b8e2fa6 on sh4nks:master.

Copy link
Collaborator

@gergelypolonkai gergelypolonkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my sole comment; otherwise LGTM, thanks for the fix!

So we can use it to apply library-specific adjustments to the code.
@sh4nks sh4nks merged commit fe92a3b into pallets-eco:master May 31, 2020
@sh4nks
Copy link
Collaborator

sh4nks commented May 31, 2020

Thanks for your PR! Sorry that it took me so long to get it merged!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants