Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugtraceback Stack Imbalancing and Bug fix #23

Merged
merged 1 commit into from
Aug 15, 2024
Merged

debugtraceback Stack Imbalancing and Bug fix #23

merged 1 commit into from
Aug 15, 2024

Conversation

singul4ri7y
Copy link
Collaborator

Changelog:

  • Migrate our debug traceback function to do string concatenation instead of using luaL_Buffer.
  • Fix bugs regarding function pushed into the Lua stack causing potential stack imbalance.

@singul4ri7y singul4ri7y changed the title Move to traditional string concatenation from luaL_Buffer debugtraceback Stack Imbalancing and Bug fix Aug 15, 2024
@singul4ri7y singul4ri7y merged commit 9c3758b into main Aug 15, 2024
1 check passed
@hugomg
Copy link
Member

hugomg commented Aug 15, 2024

I'll let you merge so you can choose how to handle the version tag etc.

@singul4ri7y singul4ri7y deleted the concatenation-migration branch August 17, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugomg hugomg hugomg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@singul4ri7y @hugomg