Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reading mpesa config data from config file instead of environment variables. #4

Merged
merged 8 commits into from
Jun 26, 2024

Conversation

amosmachora
Copy link
Collaborator

I have worked on the feature to read mpesa config data for example MPESA_BUSINESS_SHORT_CODE and CONSUMER_KEY from environment varibales allowing us to use different keys for different facilities. I have ignored the config file so that it is not accidentally pushed to Github.

Copy link

@donaldkibet donaldkibet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amosmachora, LGTM, just one suggestion provide a sample config
e.g

MPESACALLBACKURL: "https://example.com"

Its should just define what goes into the env file and format

Copy link

@ojwanganto ojwanganto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @amosmachora. I defer to @donaldkibet and @makombe for further reviews.

@amosmachora
Copy link
Collaborator Author

Thanks @amosmachora, LGTM, just one suggestion provide a sample config e.g

MPESACALLBACKURL: "https://example.com"

Its should just define what goes into the env file and format

We only use one callback URL since its our app that receives the data from saf. I have sent a sample config file to both you and @ojwanganto on slack.

@amosmachora amosmachora merged commit 538bcf2 into main Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants