Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: correct data type on confirmation and validation #12

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

amosmachora
Copy link
Collaborator

This PR fixes the endpoints safaricom hits with correct responses to avoid failing requests as we wait for @Injiri to configure the validtion and confirmation URLs

Copy link
Contributor

@Murithijoshua Murithijoshua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Murithijoshua Murithijoshua merged commit d09e1cf into main Aug 30, 2024
@Injiri
Copy link

Injiri commented Sep 2, 2024

@amosmachora let me put this here for reference
setup is as below for the respective parameters for Buy Goods integration for Lipa Na M-PESA/STKPUSH

{ 
  BusinessShortcode – short code used during Go Live
  PartyB – Till Number (where customers usually pay to) 
  TransactionType – CustomerBuyGoodsOnline.
}

@ojwanganto
Copy link

Thanks, @Injiri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants