Feat: optional authorization context #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somenugget
changed the title
palkan
reviewed
Nov 25, 2019
| @@ -49,11 +49,15 @@ def initialize(*args, **params) | |||
| @authorization_context = {} | |||
|
|
|||
| self.class.authorization_targets.each do |id, opts| | |||
| raise AuthorizationContextMissing, id unless params.key?(id) | |||
| if opts[:optional] == true | |||
| val = nil | |||
There was a problem hiding this comment.
Wouldn't it clear the value if it's passed? Can we add a test with OptionalRoleTestPolicy.new(role: some_role)?
There was a problem hiding this comment.
True. My bad.
Already fixed 👌🏻
palkan
reviewed
Nov 25, 2019
palkan
requested changes
Nov 25, 2019
There was a problem hiding this comment.
And let's also update the documentation: https://github.com/palkan/action_policy/blob/master/docs/authorization_context.md
It's already there https://github.com/palkan/action_policy/pull/95/files#diff-0a246b3b403e2dba66a4867a91b6d2e7R22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
As suggested in #89 (comment)
it allows making authorization context optional
What changes did you make? (overview)
Don't raise
AuthorizationContextMissingfromActionPolicy::Policy::Authorizationif authorization target was defined with hasoptional: truePR checklist: