Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'bad URI' due to spaces in box file name #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Javanater
Copy link

No description provided.

@paleozogt
Copy link
Owner

@Javanater I'm not sure what this is supposed to fix. The box file really does have spaces in it.

For example, if I download the box zip manually you can see the space:

➜  wget https://az792536.vo.msecnd.net/vms/VMBuild_20190311/Vagrant/MSEdge/MSEdge.Win10.Vagrant.zip
   ...
➜  unzip -l MSEdge.Win10.Vagrant.zip
Archive:  MSEdge.Win10.Vagrant.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
7189641882  2019-03-19 12:53   MSEdge - Win10.box
---------                     -------
7189641882                     1 file

@Javanater
Copy link
Author

@paleozogt, yes I see the space too. When I run make msvc14, I get a 'bad uri' error when the 'vagrant box add --force "$box_file" --name "$box_file"' command is executed. This is fixed by removing the spaces in the box file name. I see now that I did not add a line to rename the file once it is downloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants