feat: add last_id for alerts poll - #125
Merged
Merged
Conversation
palazzem
changed the title
last_id for alerts poll
palazzem
self-requested a review
October 24, 2023 09:26
Pull Request Test Coverage Report for Build 6619445658
💛 - Coveralls |
palazzem
reviewed
Oct 24, 2023
palazzem
left a comment
palazzem
left a comment
Owner
There was a problem hiding this comment.
Great change! I would say we should verify it in the HA integration, and then we can merge! No changes needed at the moment!
palazzem
approved these changes
Oct 24, 2023
palazzem
left a comment
palazzem
left a comment
Owner
There was a problem hiding this comment.
All good, QA testing works, so we're good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
With this change we add the support for verify the last id in the alerts for polling updates
Testing:
Extra Notes (optional):
Checklist