refactor!: modify the response for query.ALERTS - #119
Merged
Conversation
palazzem
requested changes
Oct 17, 2023
palazzem
left a comment
palazzem
left a comment
Owner
There was a problem hiding this comment.
I think this is a great change to make consistent responses, especially now that we unified the query() function. The only thing we should discuss is how to handle anomalies_led as in the test it should be False as a value of 1, represents no anomalies.
Let's discuss more!
palazzem
changed the title
query.ALERTS
palazzem
approved these changes
Oct 17, 2023
palazzem
left a comment
palazzem
left a comment
Owner
There was a problem hiding this comment.
Perfect, let's merge it! Thank you so much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
This PR propose to modify how the alerts are reported by the query.ALERTS to align the structure as query.SECTORS or query.INPUTS
Testing:
Extra Notes (optional):
old structrure: 'alarm_led': 0
new structure: 0: {"name": "alarm_led", "status": False}
Checklist