refactor!: add query.ALERTS to query the system - #118
Merged
Conversation
palazzem
requested changes
Oct 12, 2023
palazzem
left a comment
palazzem
left a comment
Owner
There was a problem hiding this comment.
Great change that creates a single API to query the system/cloud! Few small changes and we're good to go!
palazzem
changed the title
query.ALERTS to query the system
palazzem
approved these changes
Oct 12, 2023
palazzem
left a comment
palazzem
left a comment
Owner
There was a problem hiding this comment.
Thanks for addressing the feedback! we're good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Integrate the actual get_status def into query def under query.ALERTS for better future development
Testing:
Extra Notes (optional):
Checklist