Skip to content

AuditV3 Logging Formatting#848

Merged
bulldozer-bot[bot] merged 4 commits intodevelopfrom
bmarcaurele/audit-log-sls-formatting
Dec 17, 2025
Merged

AuditV3 Logging Formatting#848
bulldozer-bot[bot] merged 4 commits intodevelopfrom
bmarcaurele/audit-log-sls-formatting

Conversation

@bmarcaur
Copy link
Contributor

@bmarcaur bmarcaur commented Nov 28, 2025

Before this PR

v3 Audit logs did not have a formatter. Even worse is that v3 is not even represented on the API.

After this PR

v3 Audit types now have formatters and are properly represented on the API. Plan is to use this change to further break out audit logs in our CI so devs can see their audit changes more easily.

Note

I purposely left out v2 as we are rapidly moving away from it and most new audit is authored with v3 in mind. Meaning that is what most devs want to see.

⚠️ Full disclosure, the first pass of this was authored by Claude with a lengthy planning process.

@changelog-app
Copy link

changelog-app bot commented Nov 28, 2025

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

AuditV3 Logging Formatting

Check the box to generate changelog(s)

  • Generate changelog entry

@bmarcaur bmarcaur changed the title [WIP] AuditV2 and AuditV3 Logging Formatting [WIP] AuditV3 Logging Formatting Dec 12, 2025
@bmarcaur bmarcaur force-pushed the bmarcaurele/audit-log-sls-formatting branch 3 times, most recently from 48c5462 to 476f72a Compare December 12, 2025 18:39
@bmarcaur bmarcaur changed the title [WIP] AuditV3 Logging Formatting AuditV3 Logging Formatting Dec 12, 2025
@changelog-app
Copy link

changelog-app bot commented Dec 12, 2025

Successfully generated changelog entry!

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.


📋Changelog Preview

✨ Features

  • AuditV3 Logging Formatting (#848)

@bmarcaur bmarcaur marked this pull request as ready for review December 12, 2025 18:55
@bmarcaur bmarcaur force-pushed the bmarcaurele/audit-log-sls-formatting branch from 476f72a to ba1e93b Compare December 12, 2025 18:56
ganelo
ganelo previously approved these changes Dec 12, 2025
@policy-bot policy-bot bot dismissed ganelo’s stale review December 12, 2025 19:33

Invalidated by push of 6259aa0

@bmarcaur bmarcaur requested a review from ganelo December 13, 2025 16:44
Copy link
Contributor

@aldexis aldexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my one comment, this seems reasonable to me. I'll leave it to @ganelo to look at the audit log formatting itself to confirm this is what we'd like

write-locks
@bmarcaur
Copy link
Contributor Author

Other than my one comment, this seems reasonable to me. I'll leave it to @ganelo to look at the audit log formatting itself to confirm this is what we'd like

This also isn't meant to be machine readable, i.e. it's not an API, meaning it can improve or change rather trivially. I don't want the perfect to be the enemy of the better here.

@bulldozer-bot bulldozer-bot bot merged commit 6b1d5a7 into develop Dec 17, 2025
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the bmarcaurele/audit-log-sls-formatting branch December 17, 2025 19:18
@autorelease3
Copy link

autorelease3 bot commented Dec 17, 2025

Released 2.24.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants