AuditV3 Logging Formatting#848
Merged
bulldozer-bot[bot] merged 4 commits intodevelopfrom Dec 17, 2025
Merged
Conversation
Generate changelog in
|
AuditV2 and AuditV3 Logging FormattingAuditV3 Logging Formatting
48c5462 to
476f72a
Compare
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview✨ Features
|
476f72a to
ba1e93b
Compare
ganelo
previously approved these changes
Dec 12, 2025
...ormatting/src/main/java/com/palantir/witchcraft/java/logging/format/AuditLogV3Formatter.java
Outdated
Show resolved
Hide resolved
Invalidated by push of 6259aa0
aldexis
reviewed
Dec 17, 2025
...logging-formatting/src/main/java/com/palantir/witchcraft/java/logging/format/LogVisitor.java
Show resolved
Hide resolved
write-locks
Contributor
Author
This also isn't meant to be machine readable, i.e. it's not an API, meaning it can improve or change rather trivially. I don't want the perfect to be the enemy of the better here. |
aldexis
approved these changes
Dec 17, 2025
|
Released 2.24.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
v3Audit logs did not have a formatter. Even worse is thatv3is not even represented on the API.After this PR
v3Audit types now have formatters and are properly represented on the API. Plan is to use this change to further break out audit logs in our CI so devs can see their audit changes more easily.Note
I purposely left out
v2as we are rapidly moving away from it and most new audit is authored withv3in mind. Meaning that is what most devs want to see.