deprecation: Don't show errors on imports and exports

src/rules/deprecationRule.ts

@@ -59,6 +59,13 @@ function walk(ctx: Lint.WalkContext<void>, tc: ts.TypeChecker) {
                 }
             }
         } else {
+            switch (node.kind) {
+                case ts.SyntaxKind.ImportDeclaration:
+                case ts.SyntaxKind.ImportEqualsDeclaration:
+                case ts.SyntaxKind.ExportDeclaration:
+                case ts.SyntaxKind.ExportAssignment:
+                    return;
+            }
             return ts.forEachChild(node, cb);
         }
     });
@@ -90,13 +97,12 @@ function isDeclaration(identifier: ts.Identifier): boolean {
         case ts.SyntaxKind.PropertyDeclaration:
         case ts.SyntaxKind.PropertyAssignment:
         case ts.SyntaxKind.EnumMember:
+        case ts.SyntaxKind.ImportEqualsDeclaration:
             return (parent as ts.NamedDeclaration).name === identifier;
         case ts.SyntaxKind.BindingElement:
-        case ts.SyntaxKind.ExportSpecifier:
-        case ts.SyntaxKind.ImportSpecifier:
-            // return true for `b` in `import {a as b} from "foo"`
-            return (parent as ts.ImportOrExportSpecifier | ts.BindingElement).name === identifier &&
-                (parent as ts.ImportOrExportSpecifier | ts.BindingElement).propertyName !== undefined;
+            // return true for `b` in `const {a: b} = obj"`
+            return (parent as ts.BindingElement).name === identifier &&
+                (parent as ts.BindingElement).propertyName !== undefined;
         default:
             return false;
     }

test/rules/deprecation/other.test.ts

@@ -1,5 +1,8 @@
 /** @deprecated reason */
-export function other() {}
+export function other(): void;
+/** not deprecated */
+export function other(num: number);
+export function other(_num?: number) {}
 
 /** @deprecated */
 export let other2: Function;
@@ -11,4 +14,4 @@ export let notDeprecated2: any;
 
 /** @deprecated deprecated default export */
 let def = "";
-export default def;
+export default def;

test/rules/deprecation/test.ts.lint

@@ -1,18 +1,26 @@
+// don't show an error on imports, because they don't do any harm if not used
 import def, {other, other2 as foobar, notDeprecated, notDeprecated2} from './other.test';
-       ~~~ [errmsg % ('def', 'deprecated default export')]
-             ~~~~~          [errmsg % ('other', 'reason')]
-                    ~~~~~~  [err % ('other2')]
+import * as namespaceImport from './other.test';
 import * as other2 from './other2.test';
-            ~~~~~~ [err % ('other2')]
+
 other();
 ~~~~~ [errmsg % ('other', 'reason')]
+other(1);
 foobar();
 ~~~~~~ [err % ('foobar')]
+other2;
+~~~~~~ [err % ('other2')]
+
+import tmp = namespaceImport.other;
+
+tmp;
+~~~ [errmsg % ('tmp', 'reason')]
 
 declare interface D {
     /** @deprecated */ m: () => void;
 }
 
+
 declare let d: D;
 d.m();
   ~ [err % ('m')]
@@ -52,6 +60,8 @@ A + B;
 ~     [err % ('A')]
     ~ [err % ('B')]
 
+export default A;
+
 declarationIsMissing();
 
 function fn<T>(): T;
@@ -126,4 +136,4 @@ let {f, g, h} = p;
 (function ({f, g}: I) {})
 
 [err]: %s is deprecated.
-[errmsg]: %s is deprecated: %s
+[errmsg]: %s is deprecated: %s