quotemark: bugfix for jsx quotes (#2605)

* quotemark: bugfix for jsx quotes [bugfix] `quotemark`: fix regression with jsx attributes Fixes: #2603 * Add another test
palantir · Apr 29, 2017 · bf6c8de · bf6c8de
1 parent 295bf29
commit bf6c8de
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/rules/quotemarkRule.ts b/src/rules/quotemarkRule.ts
@@ -81,7 +81,7 @@ export class Rule extends Lint.Rules.AbstractRule {
             avoidEscape: args.indexOf(OPTION_AVOID_ESCAPE) !== -1,
             jsxQuoteMark: args.indexOf(OPTION_JSX_SINGLE) !== -1
                           ? "'"
-                          : args.indexOf(OPTION_JSX_DOUBLE) ? '"' : quoteMark,
+                          : args.indexOf(OPTION_JSX_DOUBLE) !== -1 ? '"' : quoteMark,
         });
     }
 }

diff --git a/test/rules/quotemark/single/test.tsx.lint b/test/rules/quotemark/single/test.tsx.lint
@@ -0,0 +1,2 @@
+let foo = <span class='foo' id="bar" />
+                               ~~~~~ [" should be ']
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		let foo = <span class='foo' id="bar" />
		~~~~~ [" should be ']