This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
Add class name rule #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sushain97 your build status isn't reporting -- have you enabled CircleCI on your fork? |
|
@adidahiya I did (https://circleci.com/gh/sushain97/tslint-blueprint/1?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link) but for some reason the branch didn't build... |
adidahiya
reviewed
Aug 18, 2017
src/rules/blueprintClassNameRule.ts
Outdated
| return ts.forEachChild(ctx.sourceFile, callback); | ||
|
|
||
| function callback(node: ts.Node): void { | ||
| if (node.kind === ts.SyntaxKind.StringLiteral && (node as ts.StringLiteral).text.startsWith("pt-")) { |
There was a problem hiding this comment.
some suggestions on the string test:
- allow the exact literal
"pt-"to go through without a lint failure. it's not a valid blueprint class name and would be a false positive if we linted for it - check for ".pt-" as well, so we can lint things like
document.querySelector(".pt-button")
There was a problem hiding this comment.
Addressed with tests. Seems to actually be building now as well: https://circleci.com/gh/sushain97/tslint-blueprint/2?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
There was a problem hiding this comment.
(thanks for the suggestions, those cases didn't cross my mind)
sushain97
force-pushed
the
string-class-name-rule
branch
from
975c276 to
723be2c
Compare
adidahiya
approved these changes
Aug 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We error on usage of string literal Blueprint class names in order to minimize typos and ensure compile-time correctness of class references.