allow circle to build for remote branches #492
Conversation
|
@mccheah @dansanduleac I could keep pushing changes to trigger more builds if that helps? |
|
Build forks is a setting in circle - you need to change it there?
…On Wed, 20 Feb 2019 at 21:28, Yifei Huang ***@***.***> wrote:
@mccheah <https://github.com/mccheah> @dansanduleac
<https://github.com/dansanduleac>
Not sure why this one failed https://circleci.com/gh/palantir/spark/11108
(it failed to check out the commit hash) but it's been working ever
since...? I also couldn't reproduce that error because a rerun of that
build worked just fine.
I could keep pushing changes to trigger more builds if that helps?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#492 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAfQVDVqxLW4YcwBQpc3o2XSfK-yPoUJks5vPa_rgaJpZM4bENCw>
.
|
|
Do you mean "Build forked pull requests" on this page? https://circleci.com/gh/palantir/spark/edit#advanced-settings. That was already on before I started this PR |
|
Yes, that. I thought that would be enough
…On Wed, 20 Feb 2019 at 21:34, Yifei Huang ***@***.***> wrote:
Do you mean "Build forked pull requests" on this page?
https://circleci.com/gh/palantir/spark/edit#advanced-settings. That was
already on before I started this PR
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#492 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAfQVE18c3B6D4w4cE7dbO_LVGe78a40ks5vPbFEgaJpZM4bENCw>
.
|
|
Yea but it was consistently failing to fetch remote branches... i think it's because we overrode the circle checkout code. the regular code looks different. it doesn't have the branch environment variable (see "checkout" step here: https://circleci.com/gh/palantir/conjure-java-runtime/3543?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link) |
|
But this seems to work now. Let me push a few more changes or start a new PR just to confirm |
|
checkout seems to be working on new PRs, not sure what caused the previous flake: #494 |
There was a problem hiding this comment.
Think this is fine - @robert3005 would there be any reason not to introduce this anyway? Seems like it fixes some fork-based PRs.
Whoops, this broke the build so... |
Testing whether circle CI starts...