PR: Fix snippet parsing when a slash character is present #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@steff456 please add a test for this by including a function that uses this syntax for parameters over here https://github.com/palantir/python-language-server/blob/develop/test/plugins/test_completion.py#L23 And then add a test for this around https://github.com/palantir/python-language-server/blob/develop/test/plugins/test_completion.py#L160 Make sure that this runs only on the correct python version. We might need to update the python version that we use on CI as well |
Contributor
|
I agree with @goanpeca's review. |
ccordoba12
approved these changes
Nov 20, 2019
Contributor
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks @steff456, great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the syntax of the snippet when a slash (
/) character is present.Fixes spyder-ide/spyder#10761