Skip to content

Conversation

@scottkruyswyk
Copy link
Contributor

Before this PR

Unknown queries were not registered with the InternalQueryClient, thus the check done in self.streaming[query_type] was failing silently.

After this PR

Safe-check with .get()

==COMMIT_MSG==
fix silent error raised when executing unknown query
==COMMIT_MSG==

Possible downsides?

Are Docs needed?

@changelog-app
Copy link

changelog-app bot commented Apr 2, 2025

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

fix silent error raised when executing unknown query

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 2281b65 into develop Apr 2, 2025
7 of 10 checks passed
@bulldozer-bot bulldozer-bot bot deleted the sk/fix-unknown-query-path branch April 2, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants